Integrate the client's file formatting options with JDT code action handlers #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For e2e test, this PR requires redhat-developer/vscode-java#1081 to return the current file's formatting options. |
testforstephen
force-pushed
the
jinbo_formatting
branch
from
672164a
to
468a462
Compare
Signed-off-by: Sheng Chen <sheche@microsoft.com>
…andlers Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
testforstephen
force-pushed
the
jinbo_formatting
branch
from
468a462
to
72fca51
Compare
testforstephen
commented
Feb 22, 2021
Comment on lines
+34
to
+36
| <repository location="https://download.eclipse.org/eclipse/updates/4.19-I-builds/I20210217-1800/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> |
There was a problem hiding this comment.
4.19M3-I-build contains the dependent formatting changes we made in the upstream jdt.core. But the I-build doesn't contain xtend and xtext sdks, so still need fetch xtend and xtext from the old release. Once 2021-03 release is ready, we can merge these two locations back into one.
|
@testforstephen There will be another PR to remove https://github.com/redhat-developer/vscode-java/blob/master/src/extension.ts#L676 right? |
yes, @snjeza has two PRs to handle that parts, see redhat-developer/vscode-java#1631 and #1551. Once this PR is merged, then we can merge the @snjeza's. |
snjeza
approved these changes
Feb 23, 2021
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Feb 24, 2021
If using a eclipse.jdt.ls version that includes eclipse-jdtls/eclipse.jdt.ls#1657 this will finally make code-actions respect the clients shiftwidth/expandtab options and no longer include tabs when the user uses spaces. The alternative to overriding the handler would have been to document that users should include these options in their `config.settings`, but given that there is no good reason that I can think of where you don't want to respond with your local editor settings it seems justified to include this out of the box instead of requiring every user to add this.
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Feb 24, 2021
If using a eclipse.jdt.ls version that includes eclipse-jdtls/eclipse.jdt.ls#1657 this will finally make code-actions respect the clients shiftwidth/expandtab options and no longer include tabs when the user uses spaces. The alternative to overriding the handler would have been to document that users should include these options in their `config.settings`, but given that there is no good reason that I can think of where you don't want to respond with your local editor settings it seems justified to include this out of the box instead of requiring every user to add this.
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Feb 24, 2021
If using a eclipse.jdt.ls version that includes eclipse-jdtls/eclipse.jdt.ls#1657 this will finally make code-actions respect the clients shiftwidth/expandtab options and no longer include tabs when the user uses spaces. The alternative to overriding the handler would have been to document that users should include these options in their `config.settings`, but given that there is no good reason that I can think of where you don't want to respond with your local editor settings it seems justified to include this out of the box instead of requiring every user to add this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sheng Chen sheche@microsoft.com
[Jinbo Wang]: Adopt the new compilation unit API to consume the client's formatting options.
Fixes #1157
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Based on #1194